Don't parse CC output for swg.js warnings -- just fix them#18589
Merged
dreamofabear merged 2 commits intoampproject:masterfrom Oct 8, 2018
Merged
Don't parse CC output for swg.js warnings -- just fix them#18589dreamofabear merged 2 commits intoampproject:masterfrom
dreamofabear merged 2 commits intoampproject:masterfrom
Conversation
rsimha
approved these changes
Oct 8, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
…t#18589) * The 'xx.x% typed' message sometimes doesn't appear. * Revert CC output parsing and instead replace bogus types in swg.js with *.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…t#18589) * The 'xx.x% typed' message sometimes doesn't appear. * Revert CC output parsing and instead replace bogus types in swg.js with *.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: Don't parse CC output for warnings in swg.js. It doesn't work because CC actually terminates on
moduleLoad"warnings", and doesn't generate a compiled JS binary. 🤷♂️I manually replaced all relative paths in type annotations with
*in swg.js in one search/replace with regex(!|\?)\.[^>)}]*. I also verified thatamp-subscriptions-googleextension builds again and this should unbreak master.I'll chat with the SWG folks on whether we should automate this or wait for a proper fix in #18586.