Only auto enable linker on Safari 12+#18029
Merged
lannka merged 1 commit intoampproject:masterfrom Sep 13, 2018
Merged
Conversation
cramforce
approved these changes
Sep 13, 2018
Member
cramforce
left a comment
There was a problem hiding this comment.
LGTM if it works on device.
Contributor
Author
|
Verified on iOS12 device. works! |
This was referenced Sep 13, 2018
cathyxz
pushed a commit
that referenced
this pull request
Sep 14, 2018
6 tasks
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works on desktop Safari 12
Still looking for a real iOS12 device to test out.