Properly wrap our main binary in a IEFE.#1684
Merged
cramforce merged 1 commit intoampproject:masterfrom Jan 30, 2016
Merged
Conversation
This avoids problems with chrome extensions and similar browser interference. This is necessary now with closure compiler because it does not keep module functions in tact. Adds a regression test for not leaking global symbols. Fixes ampproject#1679
Contributor
|
LGTM |
Member
Author
|
Test error is unrelated (sending fix to validator test). Merging. |
cramforce
added a commit
that referenced
this pull request
Jan 30, 2016
Properly wrap our main binary in a IEFE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids problems with chrome extensions and similar browser interference.
This is necessary now with closure compiler because it does not keep module functions in tact.
Adds a regression test for not leaking global symbols.
Fixes #1679