Allow submit-{success/error} attribute on all ancestors of form elements#16771
Merged
nainar merged 1 commit intoampproject:masterfrom Jul 16, 2018
Merged
Allow submit-{success/error} attribute on all ancestors of form elements#16771nainar merged 1 commit intoampproject:masterfrom
nainar merged 1 commit intoampproject:masterfrom
Conversation
Gregable
approved these changes
Jul 16, 2018
Contributor
Author
|
Thank you! :) |
Gregable
pushed a commit
that referenced
this pull request
Jul 17, 2018
Gregable
pushed a commit
that referenced
this pull request
Jul 17, 2018
Gregable
added a commit
that referenced
this pull request
Jul 17, 2018
* cl/204828263 Reword first-person error messages. * cl/204831300 Revision bump for #16771 * cl/204921777 RulesShouldMakeSense prevents user-au * cl/204928194 Add validator test for amp-lightbox. * cl/204931642 Add validator test for amp-image-ligh * cl/204941723 AttrSpec.value and value_casei suppor * Fix linter errors. * Fix more lint errors. * Fix more lint errors.
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
* cl/204828263 Reword first-person error messages. * cl/204831300 Revision bump for ampproject#16771 * cl/204921777 RulesShouldMakeSense prevents user-au * cl/204928194 Add validator test for amp-lightbox. * cl/204931642 Add validator test for amp-image-ligh * cl/204941723 AttrSpec.value and value_casei suppor * Fix linter errors. * Fix more lint errors. * Fix more lint errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we limit the
` elements.submit-successand submit-errorto direct descendants ofDropping this restriction and adding a test.
Fixes #16500