Quick fix for dep ordering issue in closure compiler with promise polyfill.#1674
Quick fix for dep ordering issue in closure compiler with promise polyfill.#1674cramforce merged 1 commit intoampproject:masterfrom
Conversation
…yfill. Fix is not ideal, but it does come with a regression test.
|
Merging. @erwinmombay Please do a post-review. |
Quick fix for dep ordering issue in closure compiler with promise polyfill.
|
@cramforce slightly concerned with how big the latest file size became (gzipped) https://github.com/ampproject/amphtml/pull/1678/files (i'm assuming that it was caused by this change). will look into it a bit more |
|
@erwinmombay But that is not this change, right? We should binary search when it happened. |
|
@cramforce yeah thats not the exact correct delta, will update in a few minute with exact delta |
|
@cramforce heres the exact delta compared to 1 commit prior (818125b in master) https://gist.github.com/erwinmombay/7cba4c4c7ade6c059279/revisions |
|
@erwinmombay Ah, understand why the extension regression happened. I was only looking at the amp.js regression which is also unfortunate, but not caused by this. I can try sending an additional change that would fix this. |
Fix is not ideal, but it does come with a regression test.
Fixes #1670