Provides support for amp-ad type=plista#1669
Conversation
|
Thanks, @torbenbrodt! Assigning to @cramforce for review. |
ads/plista.js
Outdated
There was a problem hiding this comment.
You can use loadScript from '../src/3p' to request the URL
|
Looks great, thanks! A few comments. |
ads/plista.js
Outdated
There was a problem hiding this comment.
style nit: Please declare vars as late as possible, do not use , with let and const.
|
thx a lot for your feedback, which I really appreciate. I think we got all changes implemented. Tests are green. |
|
LGTM. Please rebase and squash commits and this is good to go. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
build failed because of timeout on ubuntu APT servers
can you please run travis again? |
|
LGTM. Merging. |
Provides support for amp-ad type=plista
Provides support for amp-ad type=plista
Contributor License Agreement (CLA) was signed