Skip to content

Provides support for amp-ad type=plista#1669

Merged
cramforce merged 1 commit intomasterfrom
unknown repository
Feb 2, 2016
Merged

Provides support for amp-ad type=plista#1669
cramforce merged 1 commit intomasterfrom
unknown repository

Conversation

@torbenbrodt
Copy link
Copy Markdown
Contributor

Provides support for amp-ad type=plista
Contributor License Agreement (CLA) was signed

@dvoytenko
Copy link
Copy Markdown
Contributor

Thanks, @torbenbrodt! Assigning to @cramforce for review.

ads/plista.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use loadScript from '../src/3p' to request the URL

@cramforce
Copy link
Copy Markdown
Member

Looks great, thanks! A few comments.

ads/plista.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: Please declare vars as late as possible, do not use , with let and const.

@torbenbrodt
Copy link
Copy Markdown
Contributor Author

thx a lot for your feedback, which I really appreciate. I think we got all changes implemented. Tests are green.

@cramforce
Copy link
Copy Markdown
Member

LGTM. Please rebase and squash commits and this is good to go.
https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@torbenbrodt
Copy link
Copy Markdown
Contributor Author

build failed because of timeout on ubuntu APT servers

Err http://us-central1.gce.archive.ubuntu.com/ubuntu/ trusty/main libprotobuf8 amd64 2.5.0-9ubuntu1
503 Service Unavailable [IP: 173.255.118.228 80]

can you please run travis again?

@cramforce
Copy link
Copy Markdown
Member

LGTM. Merging.

cramforce added a commit that referenced this pull request Feb 2, 2016
Provides support for amp-ad type=plista
@cramforce cramforce merged commit 0bcc70b into ampproject:master Feb 2, 2016
cramforce pushed a commit to cramforce/amphtml that referenced this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants