Re-bundle karma test files when non-test JS files change.#1667
Re-bundle karma test files when non-test JS files change.#1667cramforce merged 1 commit intoampproject:masterfrom
Conversation
35c4131 to
f19c1e1
Compare
test/functional/test-cid.js
Outdated
|
not on my work comp right now so cant test, but how is the update->test cycle with the change? |
|
@erwinmombay For me, updating a non-test JS file would without this change trigger a rerun on the tests, but it would not actually contain the changes. The rerun is caused by the gulp task rebuilding our dist directory which the tests only serve, but there is no rebuild. With this change the difference is that on the next test run (that is automatically triggered) you actually do get your JS changes. |
Not sure there is a better way to do this, but apparently karma only watches the test files themselves which is not really what one wants during test driven development or really ever. Fixes ampproject#1623
f19c1e1 to
f6284a1
Compare
|
The issue is that we are only including our test files with karma. |
|
But that is the right way to go it. I've seen lots of problems from just blindly including all these sources. If karma used |
|
@cramforce LGTM |
Re-bundle karma test files when non-test JS files change.
Not sure there is a better way to do this, but apparently karma only watches the test files themselves which is not really what one wants during test driven development or really ever.
Fixes #1623