Skip to content

Update dependencies for default 🌴#16195

Merged
cathyxz merged 5 commits intomasterfrom
greenkeeper/initial-default
Jun 21, 2018
Merged

Update dependencies for default 🌴#16195
cathyxz merged 5 commits intomasterfrom
greenkeeper/initial-default

Conversation

@greenkeeper
Copy link
Copy Markdown
Contributor

@greenkeeper greenkeeper bot commented Jun 20, 2018

This pull request updates all your dependencies in the group default to their latest version. Having them all up to date really is the best starting point for keeping up with new releases. As long as you have the group defined in your greenkeeper.json, Greenkeeper will look out for further dependency updates relevant to this group and make sure to always handle them together and in real-time.


🙈 How to ignore certain dependencies for this group

You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can change the dependency’s version string in the package.json file back to whatever you prefer.

To make sure Greenkeeper doesn’t nag you again on the next update of this group, you can add the dependency to this group’s ignore field in the greenkeeper.json, for example:

// greenkeeper.json
{
  "groups": {
    "frontend": {
      "packages": [
        "frontend/package.json",
        "admin-dashboard/package.json"
      ],
      "ignore": [
        "eslint",
        "standard"
      ]
    }
  }
}
👩‍💻 How to update this pull request
  # Change into your repository’s directory
  git fetch
  git checkout greenkeeper/initial-default
  npm install-test
  # Adapt your code until everything works again
  git commit -m 'chore: adapt code to updated dependencies'
  git push origin greenkeeper/initial-default
✨ How do dependency updates work with Greenkeeper?

After you merge this pull request, Greenkeeper will create a new branch whenever a dependency is updated, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

The above example shows an in-range update. 1.7.0 is included in the old ^1.6.0 range, because of the caret ^ character .
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.

However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.

This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

In this example, the new version 4.0.0 is not included in the old ^3.0.0 range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.

This means that you no longer need to check for new versions manually – Greenkeeper will keep you up to date automatically.

These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:

To get a better idea of which ranges apply to which releases, check out the extremely useful semver calculator provided by npm.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Good luck with your project and see you soon ✨

Your Greenkeeper bot 🌴

@cathyxz cathyxz merged commit 34d1977 into master Jun 21, 2018
@cathyxz cathyxz deleted the greenkeeper/initial-default branch June 21, 2018 18:15
aghassemi added a commit that referenced this pull request Jun 21, 2018
erwinmombay pushed a commit that referenced this pull request Jun 21, 2018
* Revert "Mark 4 more visual diff tests as flaky (#16214)"

This reverts commit 867e903.

* Revert "Update dependencies for default 🌴 (#16195)"

This reverts commit 34d1977.
@aghassemi
Copy link
Copy Markdown
Contributor

This was reverted.

@rsimha
Copy link
Copy Markdown
Contributor

rsimha commented Jun 21, 2018

This PR doesn't contain any lockfile updates, and shouldn't have been merged. However, the fault lies in how complicated it has become to use greenkeeper. Working on a fix.

alabiaga added a commit that referenced this pull request Jun 21, 2018
alabiaga added a commit that referenced this pull request Jun 22, 2018
…6227)

* Revert "Revert "Update dependencies for default 🌴 (#16221)"

This reverts commit f8da39e.

* Revert "Mark 4 more visual diff tests as flaky (#16214)"

This reverts commit 867e903.

* Revert "Update dependencies for default 🌴 (#16195)"

This reverts commit 34d1977.

* Revert "Fix selector (#16197)"

This reverts commit f741868.

* Revert "🐛 Position offscreen amp-story-pages using viewport widths (#16092)"

This reverts commit fa85965.

* Revert "Use performance.now over Date.now in performance metrics (#16119)"

This reverts commit 0d2b567.

* fix lint errors

* fix lint error in constructor

* Update performance-impl.js

fix more lint errors

* Update url-replacements-impl.js

more lint..

* Update test-amp-access.js

fix test error.

* Update test-amp-access-source.js

fix more tests...
@rsimha
Copy link
Copy Markdown
Contributor

rsimha commented Jun 27, 2018

Update: This is fixed. We now use Renovate, where package.json and yarn.lock are updated in the same commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants