✅ Allow <amp-wistia-player rotate-to-fullscreen>#15288
Merged
alanorozco merged 1 commit intoampproject:masterfrom May 15, 2018
Merged
✅ Allow <amp-wistia-player rotate-to-fullscreen>#15288alanorozco merged 1 commit intoampproject:masterfrom
alanorozco merged 1 commit intoampproject:masterfrom
Conversation
aghassemi
approved these changes
May 15, 2018
honeybadgerdontcare
approved these changes
May 15, 2018
| value_regex: "[0-9a-zA-Z]+" | ||
| } | ||
| attrs: { | ||
| # Does nothing, as the player iframe implements this feature internally |
Contributor
There was a problem hiding this comment.
I'm not sure these comments are necessary but you're welcome to keep them.
I did look at amp-vimeo and amp-reach-player. Neither of those have this attribute either.
Member
Author
There was a problem hiding this comment.
amp-video does. The attribute is being rolled out as compatibility is audited, etc.
Gregable
pushed a commit
that referenced
this pull request
May 15, 2018
Gregable
added a commit
that referenced
this pull request
May 16, 2018
* Fix trailing newline. * Prevent templates in amp-list. * Add new error message for inline style. * Small fixes to error categorization. * Relax some CSS animation/transition constraints * Revision bump for #15288 * Implement CSS size limitation across style amp-custom and inline styles. * A few type cleanups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(No tests, not sure if worth adding for this component.)