♻️ Use tryResolve instead of Promise.resolve with call#15143
Merged
jridgewell merged 4 commits intoampproject:masterfrom May 8, 2018
Merged
♻️ Use tryResolve instead of Promise.resolve with call#15143jridgewell merged 4 commits intoampproject:masterfrom
jridgewell merged 4 commits intoampproject:masterfrom
Conversation
1c9a494 to
8caddec
Compare
aghassemi
approved these changes
May 8, 2018
66c9ab6 to
18a9a27
Compare
This was referenced Apr 8, 2020
This was referenced Apr 30, 2020
This was referenced May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves all uses of
Promise.resolve(FUNC())totryResolve(FUNC).This both captures sync throwing errors, and resolves with the return value of the
FUNC(which may be a async rejection promise). Either way, it allows handling of errors using a#catchblock.