✨Disable auto-fullscreen for iframe players in iOS#15061
Merged
alanorozco merged 4 commits intoampproject:masterfrom May 4, 2018
Merged
✨Disable auto-fullscreen for iframe players in iOS#15061alanorozco merged 4 commits intoampproject:masterfrom
alanorozco merged 4 commits intoampproject:masterfrom
Conversation
aghassemi
approved these changes
May 3, 2018
src/service/video-manager-impl.js
Outdated
| return true; | ||
| } | ||
| const internalElement = getInternalElementFor(video); | ||
| return internalElement.tagName.toLowerCase() == 'video'; |
Contributor
There was a problem hiding this comment.
I suggest running this as the first check to short-circuit for the common amp-video case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari and iOS can only fullscreen
<video>elements directly. In cases where the player component is implemented via an<iframe>, we need to rely on a postMessage API to fullscreen. Such an API is not necessarily provided by all players.