✨ amp-geo pre-release testing #14577
Merged
erwinmombay merged 6 commits intoampproject:masterfrom Apr 12, 2018
Merged
Conversation
cramforce
reviewed
Apr 12, 2018
extensions/amp-geo/0.1/amp-geo.js
Outdated
| if (getMode(this.win).geoOverride && | ||
| (isCanary(this.win) || getMode(this.win).localDev) && | ||
| getMode(this.win).geoOverride.match(/\w+/)) { | ||
| getMode(this.win).geoOverride.match(/^\w+$/)) { |
Member
There was a problem hiding this comment.
/^\w+$/.test(getMode(this.win).geoOverride) is faster (not capture created) and a bit more readable.
I'd consider adding this test at the end of the function and neutralizing this.country if it fails.
Contributor
Author
There was a problem hiding this comment.
this.country_ has a default value it picked up from the SCS hotpatch so I'm testing before I overwrite it. Will make the regex change.
erwinmombay
reviewed
Apr 12, 2018
examples/amp-geo.amp.html
Outdated
|
|
||
| body.amp-geo-group-anz { | ||
| transform: rotate(180deg); | ||
| transition: transform 0.5s 0.2s; |
glevitzky
pushed a commit
that referenced
this pull request
Apr 27, 2018
* Fix sanitizer regex * handlbars to indiclate templated hotpatch bar * css fix on example * New test pattern per PR #14432 * fixes per pr comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amp-geoWIP changes