Adds validation rules for the new animation presets in amp-story#14157
Merged
honeybadgerdontcare merged 10 commits intoampproject:masterfrom Mar 21, 2018
Merged
Conversation
Contributor
Author
|
/cc @gmajoulet @newmuis |
gmajoulet
approved these changes
Mar 20, 2018
honeybadgerdontcare
requested changes
Mar 20, 2018
| "twirl-in|" | ||
| "whoosh-in-left|" | ||
| "whoosh-in-right)" | ||
| "whoosh-in-right|" |
Contributor
There was a problem hiding this comment.
Please alphabetize here and below.
honeybadgerdontcare
approved these changes
Mar 21, 2018
Gregable
pushed a commit
that referenced
this pull request
Mar 22, 2018
Gregable
added a commit
that referenced
this pull request
Mar 22, 2018
Member
|
These validator changes will be live everywhere within an hour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validation rules and tests the new animation presets for amp-story introduced in #13910.