Skip to content

📖 Adds documentation of new animations#14149

Merged
newmuis merged 1 commit intoampproject:masterfrom
Enriqe:amp-story-docs
Mar 27, 2018
Merged

📖 Adds documentation of new animations#14149
newmuis merged 1 commit intoampproject:masterfrom
Enriqe:amp-story-docs

Conversation

@Enriqe
Copy link
Copy Markdown
Contributor

@Enriqe Enriqe commented Mar 20, 2018

Adds to amp-story readme the new preset animations introduced in #13910

@Enriqe
Copy link
Copy Markdown
Contributor Author

Enriqe commented Mar 20, 2018

/cc @newmuis

@newmuis
Copy link
Copy Markdown
Contributor

newmuis commented Mar 20, 2018

Had this been added to the validator yet? We don't want to push the documentation until it's actually possible to use the feature.

@Enriqe
Copy link
Copy Markdown
Contributor Author

Enriqe commented Mar 20, 2018

Had this been added to the validator yet? We don't want to push the documentation until it's actually possible to use the feature.

Didn't realize attribute values were also validated, woops! Will update the PR with the validation rules soon.

@Enriqe
Copy link
Copy Markdown
Contributor Author

Enriqe commented Mar 20, 2018

Validation rules are being added in #14157.

@newmuis
Copy link
Copy Markdown
Contributor

newmuis commented Mar 21, 2018

Are there additional CSS rules or DOM structure that people need to keep in mind for these animations? Or can they use it out of the box on any element? 😄

@Enriqe
Copy link
Copy Markdown
Contributor Author

Enriqe commented Mar 21, 2018

Are there additional CSS rules or DOM structure that people need to keep in mind for these animations? Or can they use it out of the box on any element? 😄

Zoom should work out of the box for any element since it's only scaling. The panning might need some explanation about the sizing though. But maybe it makes more sense to illustrate this in the amp-by-example article?

Already doing some work in #1202 with @sebastianbenz

@newmuis newmuis self-requested a review March 27, 2018 16:29
@newmuis newmuis merged commit 6469de8 into ampproject:master Mar 27, 2018
@Enriqe Enriqe deleted the amp-story-docs branch April 20, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants