eslint: remove deprecated rulePaths#12350
Merged
aghassemi merged 1 commit intoampproject:masterfrom Dec 7, 2017
Merged
Conversation
dreamofabear
approved these changes
Dec 7, 2017
Contributor
|
Good catch. I'm in the process of upgrading to the latest version of |
Contributor
|
@aghassemi: FYI, I've sent out #12450, which upgrades |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rulePathshad been deprecated in favor of--rulesdirand in eslint >4 - which we recently upgrade to - it is now an error, I am removing it since it is breaking eslint plugins for editors like Visual Studio code.Note that this does not impact
gulp lintsince ourlint.jsmanually sets this path an as option ongulp-eslintand I verified that custom rules continue to work withgulp lint.