Remove usage of innerHTML for constant templates#11633
Merged
alanorozco merged 4 commits intoampproject:masterfrom Oct 11, 2017
Merged
Remove usage of innerHTML for constant templates#11633alanorozco merged 4 commits intoampproject:masterfrom
alanorozco merged 4 commits intoampproject:masterfrom
Conversation
e327c02 to
b0da4ab
Compare
newmuis
approved these changes
Oct 11, 2017
Contributor
newmuis
left a comment
There was a problem hiding this comment.
This is really useful for creating deep, complex, static DOM trees without innerHTML. /cc @dvoytenko is this something that is useful more generally in AMP?
|
My 2c: probably not since most AMP components aren't as opinionated about layout/design as |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11545