Stop stubbing fetch and fetchJson in A4A tests#10594
Merged
keithwrightbos merged 4 commits intoampproject:masterfrom Jul 24, 2017
google:custom-fetch-mock
Merged
Stop stubbing fetch and fetchJson in A4A tests#10594keithwrightbos merged 4 commits intoampproject:masterfrom google:custom-fetch-mock
keithwrightbos merged 4 commits intoampproject:masterfrom
google:custom-fetch-mock
Conversation
glevitzky
approved these changes
Jul 24, 2017
| route.called = true; | ||
| return Promise.resolve( | ||
| typeof route.response == 'function' ? route.response() : | ||
| route.response) |
Contributor
There was a problem hiding this comment.
Was this the intended spacing?
Member
Author
There was a problem hiding this comment.
gulp lint did that. I'll see if I can find anything less ugly that it's happy with...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now directly stub
window.fetchusing a hand-rolledFetchMockclass. This will facilitate refactoring of the keyset fetcher.One of the PRs that #9040 is being split into. Related to #7618. Follow-up to #10269.