Stop overriding extractCreativeAndSignature in impls#10269
Merged
keithwrightbos merged 5 commits intomasterfrom Jul 11, 2017
Merged
Stop overriding extractCreativeAndSignature in impls#10269keithwrightbos merged 5 commits intomasterfrom
keithwrightbos merged 5 commits intomasterfrom
Conversation
jonkeller
reviewed
Jul 10, 2017
| TEST_URL, | ||
| SIGNATURE_HEADER, | ||
| } from './utils'; | ||
| import {AMP_SIGNATURE_HEADER} from '../amp-a4a'; |
Contributor
There was a problem hiding this comment.
Can combine this with the one 3 lines below
jonkeller
reviewed
Jul 10, 2017
| it('should return body and signature and size', () => { | ||
| const creative = 'some test data'; | ||
| const headerData = { | ||
| 'X-AmpAdSignature': 'AQAB', |
Contributor
There was a problem hiding this comment.
Out of curiosity, what does AQAB stand for?
Contributor
There was a problem hiding this comment.
Oh, duh, it's just some base64-encoded string. Got it.
jonkeller
reviewed
Jul 10, 2017
|
|
||
| it('without signature', () => { | ||
| const headers = { | ||
| it('without analytics', () => { |
Contributor
There was a problem hiding this comment.
Nit: Could this test name be made more clear? I get that it's no less clear than 'without signature' was, but still not as descriptive as it could be. Ditto 'with analytics'.
jonkeller
approved these changes
Jul 10, 2017
Contributor
jonkeller
left a comment
There was a problem hiding this comment.
Approve, subject to combining the imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractCreativeAndSignatureis now common to all impls exceptfake-impl. Network-specific behavior is now inextractSize. This will facilitate having two different signature schemes.One of the PRs that #9040 is being split into. Related to #7618. Follow-up to #10127.