🐛 [Story video] Prerendered video unmounted fails to play#38264
Closed
mszylkowski wants to merge 8 commits intoampproject:mainfrom
Closed
🐛 [Story video] Prerendered video unmounted fails to play#38264mszylkowski wants to merge 8 commits intoampproject:mainfrom
mszylkowski wants to merge 8 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Jun 6, 2022
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
* use 16.15.0 * legacy peer deps * lts * protobuf
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
…tml into prerendervideo_unmount2
…tml into prerendervideo_unmount2
|
@mszylkowski do you know why it's not in stable yet ? |
Contributor
Author
|
The PR that got merged was #38263, but it contains the same fix. This PR got closed after the other one got merged. Have you noticed this bug still appearing in stories recently, or were you asking about this PR exclusively? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messed up #38263, need to redo PR.
Fixes #38227
Do not hide amp-video if it's already .i-amphtml-layout because that will unmount the component.