✨Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a transformed amp document#36844
Merged
erwinmombay merged 7 commits intoampproject:mainfrom Nov 10, 2021
Merged
Conversation
|
Hey @ampproject/wg-caching! These files were changed: |
80740f0 to
e0a2eb4
Compare
erwinmombay
commented
Nov 8, 2021
e0a2eb4 to
8474aa7
Compare
8474aa7 to
b4e5a5a
Compare
erwinmombay
commented
Nov 8, 2021
… transformed amp document To better improve the performance of amp-story documents we would like to allow linking to the amp-story-1.0.css to specifically improve LCP.
90d1096 to
59841f4
Compare
jridgewell
requested changes
Nov 8, 2021
Contributor
jridgewell
left a comment
There was a problem hiding this comment.
We need to add <link rel=stylesheet> support to the runtime before merging.
Gregable
approved these changes
Nov 8, 2021
gmajoulet
approved these changes
Nov 8, 2021
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
erwinmombay
commented
Nov 8, 2021
Member
Author
|
added |
Member
Author
|
@jridgewell merged #36865 PTAL |
jridgewell
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better improve the performance of amp-story documents we would like to allow linking to the amp-story-1.0.css in a transformed document to specifically improve LCP.
This feature will be implemented in the amp-toolbox optimizer