Detect if a link[rel=stylesheet] has been SSR'd/installed for an extension#36865
Conversation
2ba2992 to
6b2d5fe
Compare
jridgewell
left a comment
There was a problem hiding this comment.
I believe we're going to have some issues with the styleLoaded function in this file. At the moment, I don't believe it'll ever resolve?
|
@jridgewell is it because you're saying the css url is incorrect right? so i double checked it and earlier didn't even have an actual css anywhere (i just gave it an href that wasn't valid) and it still resolved properly. let me double check everything though
|
jridgewell
left a comment
There was a problem hiding this comment.
Ha, apparently stylesheet.ownerNode === link is perfectly fine.
|
@jridgewell thanks. i'll add a comment on that line that |
598537b to
aed527e
Compare
…nsion Some amp optimizers will in the future add a link[rel=stylesheet] for an extension to improve their performance. We need to be able to detect and not overwrite the installed styles by the external stylesheet.
be an owner of a stylesheet
aed527e to
b856705
Compare
|
@jridgewell would you mind approving again when you get a chance was having problems with bundle-size |
Some amp optimizers will in the future add a link[rel=stylesheet] for an
extension to improve their performance. We need to be able to detect and
not overwrite the installed styles by the external stylesheet.