✨ Add volume attribute to amp-video for use in amp-story-page#36693
Merged
gmajoulet merged 8 commits intoampproject:mainfrom Nov 2, 2021
Merged
✨ Add volume attribute to amp-video for use in amp-story-page#36693gmajoulet merged 8 commits intoampproject:mainfrom
gmajoulet merged 8 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
alanorozco
reviewed
Nov 1, 2021
alanorozco
approved these changes
Nov 1, 2021
Member
alanorozco
left a comment
There was a problem hiding this comment.
Approved for change in extension directory, though validator file still requires review from @ampproject/wg-caching
gmajoulet
reviewed
Nov 1, 2021
a802a73 to
369bd39
Compare
gmajoulet
approved these changes
Nov 2, 2021
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
honeybadgerdontcare
approved these changes
Nov 2, 2021
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
LGTM for validation, thank you for adding the comment.
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Nov 4, 2021
…ject#36693) * Add volume support in amp-video for amp-story. * Parse volume string to float. * Update regex for volume. * Update extensions/amp-story/1.0/media-pool.js Co-authored-by: Gabriel Majoulet <gmajoulet@google.com> * Add validator test cases. Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
banaag
pushed a commit
to banaag/amphtml
that referenced
this pull request
Nov 9, 2021
…rge conflicts, if any.
Merged
banaag
added a commit
that referenced
this pull request
Nov 9, 2021
* cl/407238990 Two-way sync for PR #36693. No-op, or fixes merge conflicts, if any. * Remove extra volume attr introduced in the merge. * Update tests * Remove incorrectly updated chromeextension files Co-authored-by: Devin Mullins <twifkak@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36381
Adds support for a new volume attribute in amp-video that is embedded in amp-story-page. Based on the outcome of the design review (#36262), volume has to be in the range [0.1, 1] to avoid loading extra audio bytes that will not be played.