Skip to content

Validator rollup#36864

Merged
banaag merged 4 commits intoampproject:mainfrom
banaag:validator-rollup
Nov 9, 2021
Merged

Validator rollup#36864
banaag merged 4 commits intoampproject:mainfrom
banaag:validator-rollup

Conversation

@banaag
Copy link
Copy Markdown
Contributor

@banaag banaag commented Nov 9, 2021

@banaag banaag requested review from antiphoton and twifkak November 9, 2021 17:36
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Nov 9, 2021

Hey @ampproject/wg-caching! These files were changed:

extensions/amp-video/validator-amp-video.protoascii

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 9, 2021

This pull request introduces 18 alerts when merging d6f76e6 into 5fdd794 - view on LGTM.com

new alerts:

  • 8 for Expression has no effect
  • 6 for Inefficient regular expression
  • 2 for Useless assignment to local variable
  • 1 for Inconsistent use of 'new'
  • 1 for Missing variable declaration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants