🌸 Cherry-pick request for #34024 into #34244 (Approved) #34260
Description
Cherry-pick request
| Issue | PR | Beta / Experimental? | Stable? | LTS? | Release issue |
|---|---|---|---|---|---|
| #34024 | #34030 | NO | YES | NO | #34244 |
Why does this issue meet the cherry-pick criteria?
Stories with "swipe up" links are broken when embedded in the open source player. Publishers have noticed the issue and are asking for an imminent resolution.
Why is a Beta / Experimental cherry-pick not needed?
The fix is already in beta, but not stable. The current stable will also be promoted to LTS next week, so we want to get it in before it's promoted.
List the steps to manually verify the changes in this cherry-pick
- Go to https://codepen.io/capauwels/full/KKaEEjN
- Trigger the swipe up by swiping up in a mobile emulation or clicking.
Expected: Page should open in the parent window.
Actual: Page is opened inside the player
Mini-postmortem
Summary
#33656 introduced a change in outlink navigation for swipe up. By not using the navigator anymore, we essentially changed from target="_top" to target="self".
Impact
- Stories using page attachment inside a viewer.
Action Items
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers