Skip to content

Reduce the frequency and number of amphtml package upgrades #28322

@rsimha

Description

@rsimha

Background:

The amphtml repo has >150 dependencies in package.json. We use renovate to keep them up to date.

Advantages:

Disadvantages:

Purpose of this issue:

To identify a way to reduce the number of PRs while continuing to keep dependencies up to date.

Some ideas:

  1. Reduce the number of amphtml dependencies: This is easier said than done. We do frequent clean-ups of unnecessary packages, but our toolchain is large, and rewriting the functionality natively is not an option.
  2. Merge all upgrades at night: Today upgrades that pass Travis are merged manually, so we can't rely on the presence of a developer during non-working hours. Also, this doesn't reduce the PR count.
  3. Allow upgrades that pass Travis to be auto-merged at night: This will require giving write permissions to renovate, which we've been hesitant to do. This too doesn't reduce the PR count.
  4. Consolidate all MINOR and PATCH upgrades into a single PR per day: This will reduce the number of PRs, but can substantially increase the trouble involved in debugging and fixing a breaking change. It can also require frequent auto-rebasing by renovate.
  5. Find some other meaningful grouping of package upgrades: Renovate has some native grouping functionality, but it isn't clear how we can use it.

Other ideas?

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions