Prevent duplicated script to hide admin bar in onboarding wizard#6877
Merged
westonruter merged 5 commits intoampproject:developfrom Feb 8, 2022
Merged
Conversation
|
|
…to avoid duplicate script render
c620b1a to
c86439b
Compare
delawski
approved these changes
Feb 8, 2022
Collaborator
delawski
left a comment
There was a problem hiding this comment.
Thanks for your work, @NikhilJoshua!
The code looks good to me. I left one minor comment about unit tests.
Comment on lines
+197
to
+198
| add_action( 'wp_head', 'amp_remove_admin_bar_in_phone_preview' ); | ||
| add_action( 'amp_post_template_head', 'amp_remove_admin_bar_in_phone_preview' ); |
Collaborator
There was a problem hiding this comment.
Should we maybe add a unit test to confirm that those two hooks are added?
Contributor
Author
There was a problem hiding this comment.
@delawski There's no test case for amp_init() function so I didn't add it. Let me know your thoughts on it.
Collaborator
There was a problem hiding this comment.
I'll defer to @westonruter who's now free to do the final review.
Co-authored-by: Piotr Delawski <delawski@users.noreply.github.com>
westonruter
approved these changes
Feb 8, 2022
Member
westonruter
left a comment
There was a problem hiding this comment.
The E2E test is a nice touch 👍
Comment on lines
+25
to
+28
| // Checks for admin bar in iframe phone preview. | ||
| const iframeElement = await page.$( 'iframe[name="amp-wizard-completion-preview"]' ); | ||
| const previewFrame = await iframeElement.contentFrame(); | ||
| await expect( previewFrame ).not.toMatchElement( '#wpadminbar' ); |
westonruter
added a commit
that referenced
this pull request
Feb 8, 2022
Co-authored-by: Piotr Delawski <delawski@users.noreply.github.com> Co-authored-by: Nikhil Joshua <nikhiljoshua.a@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6643
Changes in PR prevent scripts to be printed multiple times on the page to hide the admin bar in the onboarding wizard.
Checklist