Prevent sanitization of Customizer preview styles#4977
Merged
westonruter merged 5 commits intodevelopfrom Jul 4, 2020
Merged
Conversation
Contributor
Author
|
@westonruter Do you think this PR also include the prevention of CSS tree shaking when the sanititization argument |
Contributor
|
Plugin builds for 9dd7976 are ready 🛎️!
|
pierlon
commented
Jul 2, 2020
westonruter
requested changes
Jul 3, 2020
westonruter
approved these changes
Jul 4, 2020
Member
westonruter
left a comment
There was a problem hiding this comment.
Something else we need to address is how the Customizer preview handles (or doesn't currently) the addition of a header video in Twenty Seventeen. Currently a YouTube video just fails to show up, and an MP4 is positioned in the wrong spot. We need to make sure that the header_video and external_header_video settings get a transport assigned of refresh as opposed to postMessage to deal with this. I'll address this as part of #4984.
Member
|
(E2E tests failing is a known issue to be fixed by #4980.) |
westonruter
added a commit
that referenced
this pull request
Jul 4, 2020
westonruter
added a commit
that referenced
this pull request
Jul 4, 2020
This was referenced Jul 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the site is being previewed in the Customizer:
data-ampdevmodeattribute to scripts so that they are ignored by sanitizersdata-ampdevmodeattribute to all dependencies of thecustomizer-previewstyle handle, including itselfallow_dirty_stylesandallow_dirty_scriptssanitizer args from the codebase as they are no longer being used anywhereFixes #4804.
Checklist