Skip to content

Fix failing tests#4507

Merged
westonruter merged 1 commit intodevelopfrom
fix/tests
Apr 2, 2020
Merged

Fix failing tests#4507
westonruter merged 1 commit intodevelopfrom
fix/tests

Conversation

@pierlon
Copy link
Copy Markdown
Contributor

@pierlon pierlon commented Apr 2, 2020

Summary

Fixes failing E2E tests and a test from the external-http test suite.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 2, 2020
'<p> <a target="_blank" title="♬ original sound - 𝐇𝐚𝐰𝐚𝐢𝐢𓆉" href="https://www.tiktok.com/music/original-sound-6689804660171082501">♬ original sound – 𝐇𝐚𝐰𝐚𝐢𝐢𓆉</a> </p></section></amp-iframe></blockquote>' . PHP_EOL . PHP_EOL,
],

'url_no_video_id' => [
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is no longer relevant.

@pierlon pierlon requested a review from westonruter April 2, 2020 00:47
@westonruter westonruter added this to the v1.5.2 milestone Apr 2, 2020
@pierlon pierlon self-assigned this Apr 2, 2020
@westonruter westonruter added the Infrastructure Changes impacting testing infrastructure or build tooling label Apr 2, 2020
@westonruter westonruter merged commit 986a307 into develop Apr 2, 2020
@westonruter westonruter deleted the fix/tests branch April 2, 2020 00:55
westonruter pushed a commit that referenced this pull request Apr 2, 2020
westonruter added a commit that referenced this pull request Apr 3, 2020
* tag '1.5.2':
  Bump 1.5.2
  Bump version to 1.5.1-RC1
  Cache response status and headers when fetching external stylesheets (#4509)
  Fix securing multi-line mustache templates (#4521)
  Add CSS monitoring time series to Site Health debugging info (#4519)
  Update hostname used for WordPress TV embeds to fix external HTTP requests (#4524)
  Fix processing of element child sanitization loop when invalid elements are replaced with children (#4512)
  Account for more YouTube URL formats (#4508)
  Update selected featured image ID on select (#4453)
  Raise default threshold for disabling CSS caching (#4513)
  Cast i-amphtml-intrinsic-sizer dimensions to integers (#4506)
  Only move meta tags to the head when required and add processing for meta[http-equiv] (#4505)
  Fix failing tests (#4507)
  Bump 1.5.2-alpha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA Infrastructure Changes impacting testing infrastructure or build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants