Use length property instead of PHP≥7.2 count() method on DOMNodeList#3727
Merged
westonruter merged 1 commit intodevelopfrom Nov 13, 2019
Merged
Use length property instead of PHP≥7.2 count() method on DOMNodeList#3727westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
pierlon
approved these changes
Nov 13, 2019
Contributor
pierlon
left a comment
There was a problem hiding this comment.
These are the only instances of where count() is used to return the value of length, so the reported issue shouldn't occur in the future.
westonruter
added a commit
that referenced
this pull request
Nov 13, 2019
westonruter
added a commit
that referenced
this pull request
Nov 14, 2019
* tag '1.4.1': (26 commits) Bump 1.4.1 Update screenshots for 1.4.1 Fix expected image name after upstream change (#3749) Use length property instead of count() method on DOMNodeList (#3727) Improve display of validation errors for scripts (#3722) Conditionally run E2E tests (#3723) Tidy up validation error details (#3721) Bump 1.4.1-RC1 Default to the homepage instead of fetching the first AMP compatible post to customize (#3715) Add missing space after sentence (#3720) Include text content of style element in validation error (#3717) Use bitwise operator. Check if element is not in top toolbar. Fix user select for meta date and author Allow right click for meta blocks Fix summarizing error sources both parent theme and child theme (#3709) Fix identifying sources for validation errors coming child themes (#3708) Fix failing E2E tests (#3707) Remove amp_validate query var from Validated URL 'View' row action (#3706) Escape instances of unescapeed output in AMP settings screen code (#3703) ...
westonruter
added a commit
that referenced
this pull request
Nov 15, 2019
…ve-duplicate-amp-scripts * 'develop' of github.com:ampproject/amp-wp: Manually add copies of AMP scripts rather than using wp_print_scripts() Add duplicate scripts to head as well Add test for removing duplicate scripts Bump stable tag to 1.4.1 Update screenshots for 1.4.1 Fix expected image name after upstream change (#3749) Use length property instead of count() method on DOMNodeList (#3727)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue reported in the support forums: https://wordpress.org/support/topic/error-1275/:
While not stated in the
DOMNodeListdocs, it appears that thecount()method was introduced in PHP 7.2 because this is when the class becameCountable:Therefore, to be compatible with older versions of PHP we must use
lengthinstead ofcount().Checklist