Fix displaying warning in editor when there is kept invalid markup#3670
Merged
westonruter merged 1 commit intodevelopfrom Oct 30, 2019
Merged
Fix displaying warning in editor when there is kept invalid markup#3670westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
Also update editor messages based on validation error rebranding
Contributor
|
Nice catch @westonruter! |
Member
Author
|
Failing tests are due to E2E issue, unrelated to changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I discovered that the warning notices in the editor do not accurately reflect the scenario when there is one or more bit of invalid markup which is kept. The issue stems from the
statusnot being included among thevalidationErrorswhich are stored.I also realized that the the messages were not updated after the rebranding in #3630. Some of the code also could be simplified. (See #3545/#3350.)
Validation Error(s) Kept
Given a URL that has errors in all 4 validation states:
Before:
After:
Validation Errors Removed
Before:
After:
Checklist