Fix infinite loop when uploading videos#3553
Merged
swissspidy merged 4 commits intodevelopfrom Oct 18, 2019
Merged
Conversation
Collaborator
|
That fails the React hooks ESLint rule. That‘s why I disabled it in my proposed fix on the issue. |
Contributor
Author
|
That is my mistake. I did see that and I knew it was needed but forgot to copy it across. Fixed now. |
miina
reviewed
Oct 18, 2019
swissspidy
approved these changes
Oct 18, 2019
westonruter
added a commit
that referenced
this pull request
Oct 18, 2019
…twentytwenty-support * 'develop' of github.com:ampproject/amp-wp: (73 commits) Mock HTTP request for Test_AMP_WordPress_TV_Embed_Handler Add test case Fix issues with image display (#3555) Fix infinite loop when uploading videos (#3553) Fix styling on remove button. (#3554) Test for XML processing instruction Undo over-eager rename of auto_accept_sanitization Rename auto-accept to accept-by-default Rename filter to amp_validation_error_auto_sanitized Fix jumping blocks when changing fonts (#3529) Update dependency browserslist to v4.7.1 (#3551) Make sure that isPageBlock always returns boolean. Fix and improve e2e tests. Remove unnessary check for block. Use shift over access first element of array. Use isPageBlock for cleaner code. Fix minor grammar issues Add docblock for `amp_is_sanitization_auto_accepted` filter Align arrows Update tests to use filter to set sanitization auto acceptance Make AMP_Validation_Manage::is_sanitization_auto_accepted() filterable ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not pass
srcin variable in theuseEffect, as the function setssrcand makes the code loop.See #3463
Checklist