Skip to content

Fix media uploader.#3487

Merged
swissspidy merged 1 commit intodevelopfrom
fix/mediaUploader
Oct 11, 2019
Merged

Fix media uploader.#3487
swissspidy merged 1 commit intodevelopfrom
fix/mediaUploader

Conversation

@spacedmonkey
Copy link
Copy Markdown
Contributor

Summary

Fixes #3463

After the refactor #3412 video upload was broken. This was because the component was expecting the mediaUpload function to be loaded on the page. This issue was found and patched upstream WordPress/gutenberg#15548 . The fix is simple, just use useSelect to get mediaUpload using a select. This is basically a copy and paste what is found in gutenberg.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 11, 2019
@swissspidy swissspidy added this to the v1.3.1 milestone Oct 11, 2019
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@swissspidy swissspidy merged commit c4997ef into develop Oct 11, 2019
@swissspidy swissspidy deleted the fix/mediaUploader branch October 11, 2019 16:47
@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploading videos broken

3 participants