Ensure all AMP scripts (including v0.js) get moved to the head#3334
Merged
westonruter merged 1 commit intodevelopfrom Sep 24, 2019
Merged
Ensure all AMP scripts (including v0.js) get moved to the head#3334westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
kienstra
approved these changes
Sep 24, 2019
Contributor
kienstra
left a comment
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good.
Like you mentioned, before, v0.js appeared in the <body> on AMP endpoints:
...but now it appears in the <head>:
| * @covers AMP_Theme_Support::prepare_response() | ||
| * @covers AMP_Theme_Support::ensure_required_markup() | ||
| */ | ||
| public function test_scripts_get_moved_to_head() { |
westonruter
added a commit
that referenced
this pull request
Sep 24, 2019
Merges #3334 into 1.3 branch
Collaborator
|
Verified in QA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a Latest Stories block on a page, this results on
amp-carouselandamp-runtimescripts being enqueued on the page, and printed in the footer. While AMP component scripts are getting moved to thehead, this was not being done forv0.js. So this ensures that no validation error from happening regardingv0.jsbeing in thebody:Steps to reproduce: