Merged
Conversation
barklund
reviewed
Sep 16, 2019
assets/src/stories-editor/blocks/amp-story-page/copy-paste-handler.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Sep 16, 2019
assets/src/stories-editor/blocks/amp-story-page/copy-paste-handler.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Sep 16, 2019
assets/src/stories-editor/blocks/amp-story-page/copy-paste-handler.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Spent a little more time working on this. Feel like we currently have is much cleaner than what we had. Did a little refactoring on this one as well, couldnt help myself. |
barklund
reviewed
Sep 17, 2019
barklund
reviewed
Sep 17, 2019
Contributor
Author
|
Fixes #3250 |
swissspidy
reviewed
Sep 17, 2019
swissspidy
reviewed
Sep 18, 2019
assets/src/stories-editor/blocks/amp-story-page/copy-paste-handler.js
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Sep 18, 2019
Collaborator
swissspidy
left a comment
There was a problem hiding this comment.
Cut / Copy / Paste seems to work fine with these changes applied.
Just left some feedback about inline docs that should be improved before merging. Otherwise LGTM.
…dler.js Co-Authored-By: Pascal Birchler <pascalb@google.com>
Contributor
Author
|
Will this go in 1.3 or 1.3.1? @swissspidy If 1.3.1, can you change the milestone? |
swissspidy
reviewed
Sep 18, 2019
assets/src/stories-editor/blocks/amp-story-page/copy-paste-handler.js
Outdated
Show resolved
Hide resolved
westonruter
added a commit
that referenced
this pull request
Oct 1, 2019
* tag '1.3.0': (318 commits) Bump 1.3.0 Add inline styles for custom fonts (#3345) Limit deeply-nesting test to 200 to fix Xdebug error (#3341) Bump 1.3-RC2 (#3335) Sanitize invalid children of amp-story and amp-story-page elements to prevent white story of death (#3336) Remove unused Travis deploy stage (#3340) Implement automated accessibility testing using Axe (#3294) Only add all Google Font style rules in editor context Prevent adding AMP query var to Story URLs in Compatibility Tool Prevent attempting to redirect Stories with rejected validation errors Ensure all AMP scripts (including v0.js) get moved to the head Make sure that media picker is background types are filter correctly. Normalize style[type] attribute quote style after r46164 in WP core Fix phpunit covers tags Bump version to 1.3-RC1 Strip 100% width/height from layout=fill elements Fix issue with cut (#3246) Remove unused Google Fonts SVGs (#3289) Fix resize for non-fit text box (#3259) Use template_dir consistently as signal for transitional mode ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cut via keyboard by using state based clipboard over the browser clipboard. This copies the logic used in the right click menu logic.
Fixes #3250