Skip to content

Update allowed tags/attributes from spec in amphtml 1907022322580#2816

Merged
westonruter merged 2 commits intodevelopfrom
update/amphtml-1907022322580
Jul 16, 2019
Merged

Update allowed tags/attributes from spec in amphtml 1907022322580#2816
westonruter merged 2 commits intodevelopfrom
update/amphtml-1907022322580

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Jul 15, 2019 •
edited
Loading

Previously #2537.

  • Run ./bin/amphtml-update.sh
  • Examine diff for changelog
  • Update spec generator as needed based on spec format changes
  • Modify validating sanitizer based on changes to spec, if needed
  • Add tests for key changes

Changelog

  • Add loop attribute on amp-youtube.
  • Add itms-services to allowed link protocols.
  • Add live-story and live-story-disabled attributes to amp-story.
  • Add theme attribute to amp-story-page-attachment.
  • Add src attribute to amp-user-location.
  • Add load-more-clickable attribute to button under amp-list-load-more.
  • Add [data-expand] attribute to section.
  • Add subscriptions-lang to globally-allowed attributes.

@westonruter westonruter added this to the v1.2.1 milestone Jul 15, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Jul 15, 2019
@westonruter westonruter marked this pull request as ready for review July 16, 2019 00:11
@westonruter westonruter requested a review from amedina July 16, 2019 00:11
@westonruter westonruter mentioned this pull request Jul 16, 2019
Merged
amedina
amedina approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@westonruter westonruter merged commit c5beedf into develop Jul 16, 2019
@westonruter westonruter deleted the update/amphtml-1907022322580 branch July 16, 2019 01:04
@westonruter westonruter mentioned this pull request Aug 8, 2019
Merged
7 tasks
petekip pushed a commit to petekip/amp-wp that referenced this pull request Jul 4, 2025
@westonruter
Merge pull request ampproject#2816 from ampproject/update/amphtml-190…
442a9ee 
…7022322580
petekip pushed a commit to petekip/amp-wp that referenced this pull request Jul 4, 2025
@westonruter
Merge pull request ampproject#2816 from ampproject/update/amphtml-190…
6111eb4 
…7022322580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amedina amedina amedina approved these changes

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@westonruter @amedina @googlebot