Skip to content

Always perform CSS tree shaking, regardless of total size#2508

Merged
westonruter merged 1 commit intodevelopfrom
remove/optional-tree-shaking
Jun 5, 2019
Merged

Always perform CSS tree shaking, regardless of total size#2508
westonruter merged 1 commit intodevelopfrom
remove/optional-tree-shaking

Conversation

@westonruter
Copy link
Copy Markdown
Member

Fixes #2501.

Remove a lot of code that is now unnecessary with removal of optional tree shaking, since it turns out that this option is obsolete.

@westonruter westonruter added the CSS label Jun 5, 2019
@westonruter westonruter added this to the v1.2 milestone Jun 5, 2019
@westonruter westonruter requested a review from amedina June 5, 2019 00:31
@googlebot googlebot added the cla: yes Signed the Google CLA label Jun 5, 2019
@westonruter
Copy link
Copy Markdown
Member Author

🕺 Eliminating some technical debt!

Copy link
Copy Markdown
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So satisfying to see so much code elimination.

@amedina
Copy link
Copy Markdown
Member

amedina commented Jun 5, 2019

Test failing because of linter (?)

@westonruter westonruter force-pushed the remove/optional-tree-shaking branch from e7c88f4 to ba15800 Compare June 5, 2019 02:16
@westonruter
Copy link
Copy Markdown
Member Author

Indeed! Amended the commit to fix the Generic.Formatting.MultipleStatementAlignment.NotSameWarning issue.

@westonruter westonruter merged commit b222d6f into develop Jun 5, 2019
@westonruter westonruter deleted the remove/optional-tree-shaking branch June 5, 2019 03:02
westonruter added a commit that referenced this pull request Jun 8, 2019
westonruter added a commit that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate CSS tree shaking from being optional

3 participants