Suppress admin bar from being shown during validation requests#2500
Merged
westonruter merged 1 commit intodevelopfrom Jun 5, 2019
Merged
Suppress admin bar from being shown during validation requests#2500westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
5 tasks
cccbf14 to
d83bb25
Compare
amedina
approved these changes
Jun 5, 2019
Member
amedina
left a comment
There was a problem hiding this comment.
Yes! Seemingly little change with large impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change always suppresses the admin bar from being shown when performing a validation request. This ensures that user-initiated validation requests perform the same as validation requests initiated by the WP-CLI command
wp amp validate-site, which does so as an unauthenticated user. Unauthenticated users should not be shown the admin bar, and normal site visitors who read AMP content (such as via an AMP Cache) are not authenticated, so it doesn't make sense to include the admin bar when doing validation.This will further prevent confusion when saving a post and there being validation errors reported, but when the user goes to the post on the frontend they see no problem because the admin bar would have been hidden entirely already via #2346.
This does not change what the user sees when browsing AMP pages served by WordPress.
See #1921.
Before
After