Remove requirement that curl multi functions exist#2423
Merged
westonruter merged 1 commit intodevelopfrom May 26, 2019
Merged
Conversation
This was referenced May 25, 2019
Member
Author
|
Cherry-picked onto 1.1 branch: a680626 This missed the 1.1.2 release so I'm re-milestoning for 1.1.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
FasterImagehas fallback support for when cURL Multi is disabled (see willwashburn/fasterimage#18 and #2422), we can remove these functions from being a dependency for the AMP plugin to work.This partly reverts #2319 to address this feedback: #2183 (comment)
Eventually the plugin should integrate with Site Health to warn when the functions are not available, since performance is slowed greatly. See #2199.
Builds for testing: