Check that required classes/functions have not been disabled#2319
Merged
westonruter merged 1 commit intodevelopfrom May 15, 2019
Merged
Check that required classes/functions have not been disabled#2319westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
westonruter
commented
May 14, 2019
| // See composer.json for this list. | ||
| $_amp_required_extensions = array( | ||
| 'curl', | ||
| 'date', |
Member
Author
There was a problem hiding this comment.
I removed date because this is actually a WordPress dependency.
swissspidy
approved these changes
May 15, 2019
Collaborator
swissspidy
left a comment
There was a problem hiding this comment.
This stuff gets more and more complex 🙃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking that the required PHP extensions are present is not enough, as some of the functions/classes in these extensions may be disabled (e.g.
curl_multi_init()). So we need to check that the functions and classes we use are actually present in addition to their extensions being loaded.Amends #2183.