Skip to content

Update allowed tags/attributes from spec in amphtml 1903141753530#2004

Merged
westonruter merged 3 commits intodevelopfrom
update/amphtml-1903141753530
Mar 20, 2019
Merged

Update allowed tags/attributes from spec in amphtml 1903141753530#2004
westonruter merged 3 commits intodevelopfrom
update/amphtml-1903141753530

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Mar 20, 2019 •
edited
Loading

Previously #1951.

  • Add amp-base-carousel component, including reference points child and lightbox-exclude.
  • Add amp-smartlinks component.
  • Forbid more values from name attribute on form elements.
  • Mandate content attributes for meta tags for amp-list-load-more and amp-recaptcha-input.
  • Add scale-end, scale-start, translate-x and translate-y to reference points for amp-story-grid-layer and amp-story-cta-layer.
  • Fix incorrect inclusion of i-amphtml-sizer.
  • Finish reviewing diff.
  • Add changelog.
  • Add tests.

@westonruter westonruter added this to the v1.1 milestone Mar 20, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 20, 2019
@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Mar 20, 2019 •
edited
Loading

Diff of changes to the validator: git diff 1903070012530...1903141753530 -- $( git ls-files 1903141753530 -- . | grep protoascii )

https://gist.github.com/westonruter/55a7392308e6e2186271fae7c3b11f9f

@westonruter westonruter marked this pull request as ready for review March 20, 2019 23:31
@westonruter westonruter requested a review from amedina March 20, 2019 23:31
amedina
amedina approved these changes Mar 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@westonruter westonruter merged commit ae64f09 into develop Mar 20, 2019
@westonruter westonruter mentioned this pull request Apr 1, 2019
Merged
@swissspidy swissspidy deleted the update/amphtml-1903141753530 branch June 18, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amedina amedina amedina approved these changes

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@westonruter @amedina @googlebot