Skip to content

Update allowed tags/attributes from spec in amphtml v1903070012530#1951

Merged
westonruter merged 3 commits intodevelopfrom
update/amphtml-v1903070012530
Mar 12, 2019
Merged

Update allowed tags/attributes from spec in amphtml v1903070012530#1951
westonruter merged 3 commits intodevelopfrom
update/amphtml-v1903070012530

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Mar 11, 2019

Previously #1891 where it was updated to v1902191749350.

  • Restrict name attribute value on a, amp-recaptcha-input, form, iframe, and slot.
  • Restrict id attribute value on amp-app-banner, amp-bind-macro, amp-live-list, amp-state, amp-story-consent, and amp-story-page.
  • Remove layout from amp-audio.
  • Add dock to amp-dailymotion and amp-delight-player.
  • Add float-in-bottom and float-in-top values to amp-fx attribute.
  • Add amp-action-macro element.
  • Review the diff and summarize changes.
  • Update tests based on changes to the spec.

Build for testing:
amp.zip (v1.1-alpha-20190311T224218Z-d6f76c14)

@westonruter westonruter added this to the v1.1 milestone Mar 11, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 11, 2019
@westonruter westonruter requested a review from amedina March 12, 2019 02:22
@westonruter westonruter merged commit b15042b into develop Mar 12, 2019
@westonruter westonruter deleted the update/amphtml-v1903070012530 branch March 12, 2019 14:08
Copy link
Copy Markdown
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants