Update amphtml from v1902072121410 to v1902191749350#1891
Merged
westonruter merged 11 commits intodevelopfrom Feb 28, 2019
Merged
Update amphtml from v1902072121410 to v1902191749350#1891westonruter merged 11 commits intodevelopfrom
westonruter merged 11 commits intodevelopfrom
Conversation
westonruter
commented
Feb 25, 2019
…phtml-1902081532110 * 'develop' of github.com:ampproject/amp-wp: Add tree shaking for :lang() selectors Eliminate renovate config since no longer need to ignore php-css-parser Add Composer patch for PHP-CSS-Parser to workaround commas in selectors Update php-css-parser to upstream v8.3.0 Update dependency fasterimage/fasterimage to v1.2.1 Run npm audit fix Improve phpdoc for comments sanitizer Deprecate the class-amp-comment-walker.php file and remove tests Fix updating comment item in amp-live-list based on new descendant comment Update dependency eslint to v5.14.1 Update contributing.md to reflect change in changelog management Remove obsolete assertion phpcs fixes Use comments sanitizer instead of custom walker Remove errant space Make comment walker filterable Remove changelog from readme Update PHP-CSS-Parser from upstream@b08df82
* Add autoscroll attribute for use by amp-sidebar component. * Add dock attribute to amp-ima-video. * Add tests for amp-sidebar autoscroll and amp-sidebar inside amp-story.
swissspidy
reviewed
Feb 27, 2019
swissspidy
reviewed
Feb 27, 2019
swissspidy
reviewed
Feb 27, 2019
swissspidy
approved these changes
Feb 28, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See release notes:
Previous update: #1862
Build for testing: amp.zip
amp-story-page-attachmentelement to AMP Stories.custom-redirect-domainattribute toamp-skimlinks.autoscrollattribute foramp-sidebarcomponent.dockattribute foramp-ima-video.textarea[autoexpand].bin/amphtml-update.shto eliminate use of Composer for amphtml dependency, and automating process for updating to latest stable version of amphtml.