Skip to content

Fix tree shaking for dynamically-added class names#1959

Merged
westonruter merged 4 commits intodevelopfrom
fix/dynamic-class-name-tree-shaking
Mar 14, 2019
Merged

Fix tree shaking for dynamically-added class names#1959
westonruter merged 4 commits intodevelopfrom
fix/dynamic-class-name-tree-shaking

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Mar 13, 2019

Prevent tree shaking CSS rules that use class names which are dynamically added, including those for:

Fixes #1946.
Fixes #1490.


Build for testing: amp.zip (1.1-alpha-20190313T180459Z-d5495203)

@westonruter westonruter marked this pull request as ready for review March 13, 2019 18:10
@westonruter westonruter requested review from felixarntz and swissspidy and removed request for felixarntz March 13, 2019 18:10
Co-Authored-By: westonruter <westonruter@google.com>
@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Mar 13, 2019
@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@westonruter westonruter added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Mar 13, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants