Add first-party support for Crowdsignal poll/survey oEmbeds#1929
Add first-party support for Crowdsignal poll/survey oEmbeds#1929westonruter merged 3 commits intodevelopfrom
Conversation
|
Confirming that since Crowdsignal/Polldaddy is a core oembed, those embeds will work in some decent way without Jetpack in AMP after this PR? |
|
@kraftbj oh, I wasn't aware that it is a core embed now. Well, without support the support of the AMP plugin or Jetpack then the sample content from Automattic/jetpack#11484 gets rendered as: In other words, the poll oEmbed successfully gets a fallback since it has The Survey oEmbed, however, renders nothing since the oEmbed response is only a <script type="text/javascript">(function(d,c,j){if(!document.getElementById(j)){var pd=d.createElement(c),s;pd.id=j;pd.src=('https:'==document.location.protocol)?'https://polldaddy.com/survey.js':'http://i0.poll.fm/survey.js';s=document.getElementsByTagName(c)[0];s.parentNode.insertBefore(pd,s);}}(document,'script','pd-embed'));</script>This lack of Nevertheless, now that Crowdsignal is actually directly supported by core, it seems actually that it shouldn't be removed. More specifically, the oEmbed handling shouldn't be removed. The shortcode handling, however, is something that should be handled rather by the Jetpack or Crowdsignal plugins since the shortcodes are not defined in core. Agree? |
3e4bd5b to
923dd57
Compare
#11484) * Add AMP support for Crowdsignal shortcodes and oEmbeds * Remove embed_oembed_html filter which remains in AMP plugin via ampproject/amp-wp#1929
508c4f0 to
50fc4a0
Compare



Related: #1925.
WPCOM_AMP_Polldaddy_EmbedtoAMP_Crowdsignal_Embed_Handler.