Include candidate hero images after paragraphs and persist loading attribute on noscript > img fallback#149
Merged
schlessera merged 4 commits intomainfrom Apr 13, 2021
Merged
Conversation
loading attribute on noscript > img fallback
4 tasks
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Apr 11, 2021
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Apr 11, 2021
afc0cda to
7f57154
Compare
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Apr 11, 2021
Member
Author
|
Upstream PR has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-hero-candidate) even when they occur after multiple paragraphs. This fixes an issue I saw in Twenty Twenty-One where there multiple paragraphs in the header, preventing any images in the entry content from being made heros via the AMP plugin'sDetermineHeroImagestransformer.loadingattribute from itsnoscript > imgfallback. If the fallbackimglacks aloadingattribute (as in the case of the Custom Logo in WordPress), omit it from the SSR'edimgas well. If the fallbackimghasloading=lazy, then add it to the SSR'ed image as well (as is done for content images in WP). Fixes Evaluate improved lazy-loading behavior for hero images #147. Done in Improve logic to detect explicitly marked hero images amp-toolbox#1198 via ampproject/amp-toolbox@16a1a85.