fix(optimizer): add missing dependency node-fetch#838
Merged
sebastianbenz merged 1 commit intoampproject:masterfrom Jun 15, 2020
Merged
fix(optimizer): add missing dependency node-fetch#838sebastianbenz merged 1 commit intoampproject:masterfrom
sebastianbenz merged 1 commit intoampproject:masterfrom
Conversation
Collaborator
|
Sorry about missing this again. Is there a simple way to check this via linter? |
Contributor
Author
No worries 👍
Yes, there is a ESLint plugin that can handle this. |
Collaborator
|
Thanks! Unfortunately, it looks like it doesn't play well with how lerna
handles dependencies.
… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
In #835
@ampproject/toolbox-optimizerstarted usingnode-fetchbut didn't declare it as a dependency.How did you fix it?
Add missing dependency
node-fetch