Skip to content

More robust cache warmup #835

Merged
sebastianbenz merged 1 commit intomasterfrom
timeout-warmup
Jun 11, 2020
Merged

More robust cache warmup #835
sebastianbenz merged 1 commit intomasterfrom
timeout-warmup

Conversation

@sebastianbenz
Copy link
Copy Markdown
Collaborator

  • timeout fetch after 2s to avoid overly long timeouts
  • explain how to configure a custom proxy
  • fix potential endless loop if fetch fails

Fixes #832


- name: `fetch`
- valid options: a [whatwg fetch](https://github.com/whatwg/fetch) compatible fetch implementation.
- default: `[node-fetch](https://www.npmjs.com/package/node-fetch)`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to wrap a markdown link inside of code ticks?

image

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was intenational, but not sure if it makes sense ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors installing @ampproject/toolbox-optimizer@2.4.0 behind proxy

3 participants