Fix: don't auto import experimental bento components #1234
Merged
sebastianbenz merged 2 commits intomainfrom May 19, 2021
Merged
Fix: don't auto import experimental bento components #1234sebastianbenz merged 2 commits intomainfrom
sebastianbenz merged 2 commits intomainfrom
Conversation
e6c04c3 to
bd730b5
Compare
Use the bento component info published here https://amp.dev/static/bento-components.json to determine which version of a component to auto import. Fixes #1221
| let bentoComponentInfo = await config.cache.get('bento-component-info'); | ||
| if (!bentoComponentInfo) { | ||
| bentoComponentInfo = await fetchBentoComponentInfo_(config); | ||
| config.cache.set('bento-component-info', bentoComponentInfo); |
Collaborator
There was a problem hiding this comment.
do we have any concern about a cache error?
Collaborator
Author
There was a problem hiding this comment.
Good point, made this handle errors with a single warning
bd730b5 to
3f6febe
Compare
patrickkettner
approved these changes
May 19, 2021
Collaborator
patrickkettner
left a comment
There was a problem hiding this comment.
one question, otherwise lgtm
sebastianbenz
added a commit
that referenced
this pull request
May 19, 2021
* Don't auto import experimental bento components Use the bento component info published here https://amp.dev/static/bento-components.json to determine which version of a component to auto import. Fixes #1221 * handle cache failures
10 tasks
sebastianbenz
added a commit
that referenced
this pull request
Jun 1, 2021
Don't auto import experimental bento components. Pull in latest component prod version from the amphtml repository. Fixes #1221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1221