Skip to content
This repository was archived by the owner on Oct 22, 2019. It is now read-only.

Update <amp-video rotate-to-fullscreen> examples#1267

Merged
sebastianbenz merged 2 commits intoampproject:masterfrom
alanorozco:rot82
May 15, 2018
Merged

Update <amp-video rotate-to-fullscreen> examples#1267
sebastianbenz merged 2 commits intoampproject:masterfrom
alanorozco:rot82

Conversation

@alanorozco
Copy link
Copy Markdown
Member

@alanorozco alanorozco commented May 15, 2018

  1. Fixes experiments link.
  2. Updates styling per UI review.
  3. Uses new firstPlay action to trigger animation instead of a position observer.

@alanorozco alanorozco requested a review from kul3r4 May 15, 2018 00:17
Copy link
Copy Markdown
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@sebastianbenz sebastianbenz merged commit ff3041b into ampproject:master May 15, 2018
@alanorozco alanorozco deleted the rot82 branch May 15, 2018 18:12
juliantoledo pushed a commit that referenced this pull request Jun 7, 2018
* Update <amp-video rotate-to-fullscreen> examples

* Typo
juliantoledo pushed a commit that referenced this pull request Jun 7, 2018
* Update <amp-video rotate-to-fullscreen> examples

* Typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants