Hi @RF-Tar-Railt, would you mind rebasing this PR to master? Recent changes made it possible to run tests as part of the PR to prevent regressions, see https://github.com/amitdev/lru-dict/pull/54/files#r1359945835

Where did the stubs go? Why were they reverted. IMO those are important in modern Python development.

Hi @RF-Tar-Railt, would you mind rebasing this PR to master? Recent changes made it possible to run tests as part of the PR to prevent regressions, see #54 (files)

updated.

@amitdev
All Build and Tests have passed.

Please note that I did not modify the version

It seems to have some conflicts @RF-Tar-Railt

It seems to have some conflicts @RF-Tar-Railt

But I don't seem to have the authority to resolve conflicts

Sorry, can you raise another PR? When I try to resolve conflict I get #56 which doesn't seem to include all changes?

All we need is probably:

git fetch --all
git reset --hard origin/master
git cherry-pick bf2faab891e0dae43108f14d875859ed995bf084
git push --force

This is assuming origin is git@github.com:amitdev/lru-dict.git, but depending on your setup/fork replace origin by upstream

All we need is probably:

git fetch --all
git reset --hard origin/master
git cherry-pick bf2faab891e0dae43108f14d875859ed995bf084
git push --force

This is assuming origin is git@github.com:amitdev/lru-dict.git, but depending on your setup/fork replace origin by upstream

use in my fork or ?

Yes you can totally do it from your fork, say upstream is configured with git@github.com:amitdev/lru-dict.git and your fork is origin with git@github.com:RF-Tar-Railt/lru-dict.git you can:

git fetch --all
git reset --hard upstream/master # erase with master change
git cherry-pick bf2faab891e0dae43108f14d875859ed995bf084
git push --force

I can walk you through on Discord I'm AndreMiras#3439

done.

Ahah I'm not sure why the PR closed though 😅

Ahah I'm not sure why the PR closed though 😅

#58 merged